Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

Jigar Raisinghani jigarraisinghani at gmail.com
Sun Mar 10 10:14:25 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109378/
-----------------------------------------------------------

(Updated March 10, 2013, 10:14 a.m.)


Review request for Calligra.


Changes
-------

Removed white space but number is necessary for F2. Qt::Key_F2 doesn't work. 


Description
-------

KAction does not support function keys(F1,F2 etc) as shortCuts. QAction does but KoToolBase does not allow for both KAction* & QAction* at the same time. 
Added an exception for F2 as needed. 

Fixed. 


This addresses bug 291624.
    http://bugs.kde.org/show_bug.cgi?id=291624


Diffs (updated)
-----

  sheets/ui/CellToolBase.cpp e66ba5b 

Diff: http://git.reviewboard.kde.org/r/109378/diff/


Testing
-------

Yes, working.


Thanks,

Jigar Raisinghani

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130310/b244b3e7/attachment.htm>


More information about the calligra-devel mailing list