Review Request 109149: Increase size of QPixmapCache to prevent flickering and infinte redraw in PictureShape

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109149/#review28783
-----------------------------------------------------------


This review has been submitted with commit 6fee9ff16afe55d0d894918161ab2cd95968fa26 by Arjen Hiemstra to branch master.

- Commit Hook


On Feb. 25, 2013, 4:09 p.m., Arjen Hiemstra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109149/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 4:09 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> With larger images, the default size of QPixmapCache is too small to properly cache the results of the scaled image used by PictureShape. This causes flickering and infinite redraws when multiple images overlap due to one image being removed from the cache when another is added. This patch changes that to use a default size equal to 5 images of 2048 x 1024 x 32bpp. This potentially increases the memory usage of documents with lots of pictures but prevents the repainting and flickering issues.
> 
> 
> Diffs
> -----
> 
>   plugins/pictureshape/Plugin.cpp 6e12b41 
> 
> Diff: http://git.reviewboard.kde.org/r/109149/diff/
> 
> 
> Testing
> -------
> 
> Build and run. Tested the pictureshape and it no longer flickers when overlapping.
> 
> 
> Thanks,
> 
> Arjen Hiemstra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130308/60d12603/attachment.htm>