Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)
Boudewijn Rempt
boud at valdyas.org
Tue Mar 5 09:28:57 GMT 2013
> On March 3, 2013, 11:38 p.m., Friedrich W. H. Kossebau wrote:
> > cmake/productsets/desktop.cmake, line 1
> > <http://git.reviewboard.kde.org/r/109071/diff/3/?file=116880#file116880line1>
> >
> > should be "wanted for Desktop OS".
With these little niggles fixed, I'd say, please merge to master. We're waiting with a patch for merging sketch to master for this patch to go in, since sketch also has changes to make creativeonly smaller.
- Boudewijn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109071/#review28509
-----------------------------------------------------------
On March 3, 2013, 11:24 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109071/
> -----------------------------------------------------------
>
> (Updated March 3, 2013, 11:24 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> PRODUCTSET is a substitute for the old non-exclusive options CREATIVEONLY and TINY (which then are handled exclusively, eek), with migration support for CREATIVEONLY flag. Predefined hardcoded productsets are ACTIVE, CREATIVE, DESKTOP, and ALL (as fallback and default).
>
> Patch also turns buildsystem to have a SHOULD_BUILD for each product (app/plugin), which then all get turned on centrally in groups depending on the productset, instead of everywhere having overlapping and hard to oversee if-else blocks deciding what gets build and what not.
>
> Not the perfect final solution, but a first step into the right direction IMHO.
>
> Known issues:
> * BUILD_AUTHOR is not yet set
>
> Patch can be also tested as branch addProductSetBuildParameter-kossebau.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt a300bd2
> CMakeLists.txt 564c0a0
> cmake/modules/CalligraProductSetMacros.cmake PRE-CREATION
> cmake/productsets/README PRE-CREATION
> cmake/productsets/active.cmake PRE-CREATION
> cmake/productsets/all.cmake PRE-CREATION
> cmake/productsets/creative.cmake PRE-CREATION
> cmake/productsets/desktop.cmake PRE-CREATION
> devtools/CMakeLists.txt f0e7b62
> devtools/cstester/CMakeLists.txt a12ea92
> doc/CMakeLists.txt 205b34a
> extras/CMakeLists.txt 70edca7
> extras/quickprint/CMakeLists.txt 1cb9cc3
> extras/thumbnail/CMakeLists.txt 9b2ef6f
> filters/CMakeLists.txt 5acecef
> filters/plan/mpxj/CMakeLists.txt 237d214
> filters/sheets/CMakeLists.txt 351a8e2
> filters/words/CMakeLists.txt 0c2107c
> kexi/CMakeLists.txt 54cdabb
> kexi/kexidb/drivers/CMakeLists.txt bfa46ad
> kexi/migration/CMakeLists.txt aff9d47
> libs/CMakeLists.txt 2036cf5
> plan/plugins/filters/CMakeLists.txt c3115da
> plugins/CMakeLists.txt 0e87b1e
> plugins/kexi/CMakeLists.txt 704736c
> plugins/reporting/CMakeLists.txt 72ae5ee
> sheets/CMakeLists.txt 9f96e41
> stage/CMakeLists.txt 94dd31c
> stage/app/CMakeLists.txt PRE-CREATION
> stage/app/Info.plist.template PRE-CREATION
> stage/app/main.cpp PRE-CREATION
> stage/app/stage.desktop PRE-CREATION
> stage/part/CMakeLists.txt de57a0f
> stage/part/Info.plist.template 857a8d7
> stage/part/main.cpp 5ef9509
> stage/part/stage.desktop 54c3be9
> words/CMakeLists.txt e6336a2
> words/app/CMakeLists.txt PRE-CREATION
> words/app/Info.plist.template PRE-CREATION
> words/app/main.cpp PRE-CREATION
> words/app/words.desktop PRE-CREATION
> words/part/CMakeLists.txt 56b8c6f
> words/part/Info.plist.template 97e1728
> words/part/main.cpp 875eb5d
> words/part/words.desktop 363860c
>
> Diff: http://git.reviewboard.kde.org/r/109071/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130305/cf0db297/attachment.htm>
More information about the calligra-devel
mailing list