Review Request 109260: Normalize SIGNAL and SLOT signatures in Stage

[Inge Wallin]

> On March 3, 2013, 6:14 p.m., Thorsten Zachmann wrote:
> > What is the difference in all the files that show no difference in reviewboard?

It's diffs of the same type as those that are visible: removing of whitespace inside SIGNAL and SLOTs.  I have no idea why they are not shown in Reviewboard.


> On March 3, 2013, 6:14 p.m., Thorsten Zachmann wrote:
> > stage/part/KPrViewModeSlidesSorter.cpp, line 318
> > <http://git.reviewboard.kde.org/r/109260/diff/1/?file=116695#file116695line318>
> >
> >     Is this removing of whitespace necessary? Having a blank after a , makes it more readable?

I agree in principle, and this "normalization" thing seems to be rather new.  However, it's pointed out as an issue at EBN: http://englishbreakfastnetwork.org/krazy/reports/bundled-apps/calligra/stage/index.html (see issue type 15.) At the bottom of that section is a link to a blog about this: http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures

I'm not sure myself how important this is but the people that I have asked tells me that it matters.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109260/#review28486
-----------------------------------------------------------


On March 3, 2013, 3:30 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109260/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 3:30 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> This is a normalization of SIGNAL and SLOT calls that is done with fixsrc.py.  By now I think it's 99% certain that it's correct but I still want somebody who knows the code to look through it.
> 
> 
> Diffs
> -----
> 
>   stage/part/KPrAnimationDirector.cpp 4b3a50d 
>   stage/part/KPrHtmlExport.cpp 9a9fc1c 
>   stage/part/KPrPart.cpp 84e4867 
>   stage/part/KPrPresentationDrawWidget.cpp 28c0264 
>   stage/part/KPrPresentationTool.cpp 3875f82 
>   stage/part/KPrPresenterViewSlidesInterface.cpp 1980981 
>   stage/part/KPrPresenterViewToolWidget.cpp a4243c7 
>   stage/part/KPrPresenterViewWidget.cpp d699c66 
>   stage/part/KPrView.cpp 078b34b 
>   stage/part/KPrViewAdaptor.cpp 1fd9051 
>   stage/part/KPrViewModePreviewPageEffect.cpp 45e33a6 
>   stage/part/KPrViewModeSlidesSorter.cpp 55b0e22 
>   stage/part/dockers/KPrPageLayoutDocker.cpp e0e3113 
>   stage/part/dockers/KPrPreviewWidget.cpp 34bca0e 
>   stage/part/tests/ModelTest.cpp 2494481 
>   stage/part/tools/animationtool/KPrAnimationSelectorWidget.cpp e603461 
>   stage/part/tools/animationtool/KPrAnimationsTimeLineView.cpp 98add38 
>   stage/part/tools/animationtool/KPrClickActionDocker.cpp 39167fd 
>   stage/part/tools/animationtool/KPrPageEffectDocker.cpp e892dd1 
>   stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp e6039ae 
>   stage/part/ui/KPrConfigureSlideShowDialog.cpp 1b046bd 
>   stage/plugins/eventactions/sound/KPrSoundEventAction.cpp 1fbb3f4 
>   stage/plugins/eventactions/sound/KPrSoundEventActionWidget.cpp 34e4267 
> 
> Diff: http://git.reviewboard.kde.org/r/109260/diff/
> 
> 
> Testing
> -------
> 
> It builds just like before.  No new failing tests.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130304/1e5b2aad/attachment.htm>