Review Request 109278: fix preedit string problem when layout the document, fix input method query problem in artistictext tool

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109278/#review28512
-----------------------------------------------------------

Ship it!


looks good. Well at least like I would expect. Having little way to test it I'm just going to take your word for it that it works.

- C. Boemann


On March 4, 2013, 3:20 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109278/
> -----------------------------------------------------------
> 
> (Updated March 4, 2013, 3:20 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> when use input method with preedit string, application will crash when layout the document.
> when using artistictext tool, input method context dialog won't update position.
> 
> 
> Diffs
> -----
> 
>   libs/textlayout/KoTextLayoutArea.cpp afbd57e 
>   libs/textlayout/KoTextLayoutArea_paint.cpp 6671e2d 
>   plugins/artistictextshape/ArtisticTextTool.h 49cd7a1 
>   plugins/artistictextshape/ArtisticTextTool.cpp dab0764 
>   plugins/textshape/TextTool.cpp decb758 
> 
> Diff: http://git.reviewboard.kde.org/r/109278/diff/
> 
> 
> Testing
> -------
> 
> most crash resolved. still one crash in testing, will investigate if that was the same issue.
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130304/79c4ede2/attachment.htm>