Review Request 109108: sync hardcoded mimetypes in Calligra Active code with those in calligraactive.desktop

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109108/#review28505
-----------------------------------------------------------


This review has been submitted with commit f529d75a1bee0f17115399d59cfc1082ea5824fb by Wolfgang Rohdewald to branch KDE/4.10.

- Commit Hook


On Feb. 22, 2013, 11:42 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109108/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2013, 11:42 p.m.)
> 
> 
> Review request for Calligra and Shantanu Tushar.
> 
> 
> Description
> -------
> 
> Follow-up to http://git.reviewboard.kde.org/r/108996
> 
> Inside CalligraActive code the mimetypes are hardcoded a second time, in the overloads of CAAbstractDocumentHandler::supportedMimetypes().
> This seems needed, because Calligra Active as a single app supports three kinds of documents, so first has to check by the mimetypes which of the three 
> document kind handler has to be used.
> 
> Attached patch is a workaround for the principal problem, syncs the list of mimetypes in the handler with those in calligraactive.desktop .
> 
> See also email "Problems with Calligra Active and mimetypes" to mailinglist calligra-devel.
> 
> Okay to backport to 2.6?
> 
> 
> Diffs
> -----
> 
>   active/src/CAPresentationHandler.cpp 319c60f 
>   active/src/CASpreadsheetHandler.cpp 62670e8 
>   active/src/CATextDocumentHandler.cpp 5f4db02 
> 
> Diff: http://git.reviewboard.kde.org/r/109108/diff/
> 
> 
> Testing
> -------
> 
> Applied patch for package for Plasma Active, loads a lot more files now
> 
> (already merged into main repo, see https://build.pub.meego.com/package/files?package=calligra&project=Project%3AKDE%3ADevel )
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130303/69f29f5e/attachment.htm>