Review Request 109260: Normalize SIGNAL and SLOT signatures in Stage

Inge Wallin inge at lysator.liu.se
Sun Mar 3 15:30:41 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109260/
-----------------------------------------------------------

Review request for Calligra and Thorsten Zachmann.


Description
-------

This is a normalization of SIGNAL and SLOT calls that is done with fixsrc.py.  By now I think it's 99% certain that it's correct but I still want somebody who knows the code to look through it.


Diffs
-----

  stage/part/KPrAnimationDirector.cpp 4b3a50d 
  stage/part/KPrHtmlExport.cpp 9a9fc1c 
  stage/part/KPrPart.cpp 84e4867 
  stage/part/KPrPresentationDrawWidget.cpp 28c0264 
  stage/part/KPrPresentationTool.cpp 3875f82 
  stage/part/KPrPresenterViewSlidesInterface.cpp 1980981 
  stage/part/KPrPresenterViewToolWidget.cpp a4243c7 
  stage/part/KPrPresenterViewWidget.cpp d699c66 
  stage/part/KPrView.cpp 078b34b 
  stage/part/KPrViewAdaptor.cpp 1fd9051 
  stage/part/KPrViewModePreviewPageEffect.cpp 45e33a6 
  stage/part/KPrViewModeSlidesSorter.cpp 55b0e22 
  stage/part/dockers/KPrPageLayoutDocker.cpp e0e3113 
  stage/part/dockers/KPrPreviewWidget.cpp 34bca0e 
  stage/part/tests/ModelTest.cpp 2494481 
  stage/part/tools/animationtool/KPrAnimationSelectorWidget.cpp e603461 
  stage/part/tools/animationtool/KPrAnimationsTimeLineView.cpp 98add38 
  stage/part/tools/animationtool/KPrClickActionDocker.cpp 39167fd 
  stage/part/tools/animationtool/KPrPageEffectDocker.cpp e892dd1 
  stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp e6039ae 
  stage/part/ui/KPrConfigureSlideShowDialog.cpp 1b046bd 
  stage/plugins/eventactions/sound/KPrSoundEventAction.cpp 1fbb3f4 
  stage/plugins/eventactions/sound/KPrSoundEventActionWidget.cpp 34e4267 

Diff: http://git.reviewboard.kde.org/r/109260/diff/


Testing
-------

It builds just like before.  No new failing tests.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130303/f945081c/attachment.htm>


More information about the calligra-devel mailing list