Review Request 109215: Branch Review for ReviewTool

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109215/#review28363
-----------------------------------------------------------

Ship it!


I say it's good enough - let's merge to master

- C. Boemann


On March 1, 2013, 6:39 a.m., Luke De Mouy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109215/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 6:39 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> As the Summary says
> 
> Note to boemann: I accidentally removed the #include for dialogs/SimpleSpellCheckingWidgets in my haste to make sure it was pushed before you left, so that's missing in the review but it's fixed in my local branch, so I'm going to need to repush but I'll wait till we're both online again unless you put the instructions here for amending that kind of situation.
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/CMakeLists.txt 4cd1b91 
>   plugins/textshape/ReviewTool.h 256f08c 
>   plugins/textshape/ReviewTool.cpp b1732be 
>   plugins/textshape/ReviewToolFactory.cpp 0f60746 
>   plugins/textshape/dialogs/SimpleSpellCheckingWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/SimpleSpellCheckingWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleSpellCheckingWidget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109215/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luke De Mouy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130301/2ad19fbf/attachment.htm>