Review Request 111044: Implement borders for shapes

[Thorsten Zachmann]

> On June 29, 2013, 3:43 a.m., Thorsten Zachmann wrote:
> > libs/odf/KoBorder.cpp, lines 1067-1068
> > <http://git.reviewboard.kde.org/r/111044/diff/2/?file=165059#file165059line1067>
> >
> >     This seems to miss handling cases there only the specialBorderString is set.
> 
> C. Boemann wrote:
>     well the ms-odf filter and our writing code will never just write the special border. the special border is providing extra info.

In the document I pointed out this seems to happen. At least with the patch this shows now a wrong border.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111044/#review35264
-----------------------------------------------------------


On June 22, 2013, 6:28 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111044/
> -----------------------------------------------------------
> 
> (Updated June 22, 2013, 6:28 a.m.)
> 
> 
> Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> This patch implements loading, saving and painting of borders for shapes in general. It also implements calls to actually paint borders in particular for the picture shape and text shape.
> 
> At the same time I moved border painting from KWCanvasBase to KoBorder, which I announced some weeks ago that I wanted to do.
> 
> A patch this deep in the libraries should not go in without a run of cstester. I would be glad for help with this since I only have a semi-weak laptop.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.h fe6cc3f 
>   libs/flake/KoShape.cpp 6d14a8c 
>   libs/flake/KoShape_p.h aa6633c 
>   libs/odf/KoBorder.h bdbf86e 
>   libs/odf/KoBorder.cpp 58f8e45 
>   plugins/pictureshape/PictureShape.cpp 976fadd 
>   plugins/textshape/TextShape.cpp b230f0a 
>   words/part/KWCanvasBase.cpp 7d12890 
> 
> Diff: http://git.reviewboard.kde.org/r/111044/diff/
> 
> 
> Testing
> -------
> 
> Tested with all the files with the string "border" in it in the test suite.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130629/ccf50c60/attachment.htm>