Review Request 111264: fix unwanted changing of m_name in DocxXmlStylesReader::read_style()

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111264/
-----------------------------------------------------------

(Updated June 29, 2013, 12:54 a.m.)


Status
------

This change has been discarded.


Review request for Calligra, Inge Wallin and Matus Uzak.


Description
-------

Saw that when going over all the usages of QString::replace(...) (which changes the object itself and returns a reference to it, as you surely know)

Looks fishy to me that m_name is changed by the call to replace on creating a name for the style. No idea if that is wanted, I rather guess not.
Matus, Inge, you are more the experts here, so please give it a check :)

Okay to backport to 2.7 & 2.6 ?


Diffs
-----

  filters/words/docx/import/DocxXmlStylesReader.cpp 8b38716 

Diff: http://git.reviewboard.kde.org/r/111264/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130629/13a22766/attachment.htm>