Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111031/
-----------------------------------------------------------

(Updated June 25, 2013, 9:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, C. Boemann, Inge Wallin, and Yue Liu.


Description
-------

As discussed now and then Calligra's libs and modules sometimes have rather generic names, like e.g. exporthtml, msooxml, textlayout, or vectorimage. It would be better behaving and possibly also easier for developers messing around in install dirs when we namespace our libs and modules and possibly also have some naming scheme where appropriate.

For a start I propose to change the names of all the filter modules, to have the prefix "calligra_filter_" and then the pattern "formatX2formatY". Attached patch renames all the modules with the pattern "calligra_filter_formatX2formatY", with variants to "formatX2formatY" where not directly applyable (should be still good enough to uniquely identify the purpose of the respective module). I also changed the cmake vars listing the source files (like vsdximport_PART_SRCS to vsdx2odg_PART_SRCS) to use the "formatX2formatY" identifier, to reduce the term variants in the CMakeLists.txt. I did not change the related source file names (like VSDXImport.cpp) though, because this would make this patch unreviewable and can be done in a different step, if wanted at all.

I also did not yet rename the desktop files, as that would need coordination with the translators and possibly should be done after 2.7.1+x release, when activity for translations of Calligra might be lower and master has got translations again (of course this patch is for master only).

Patch okay?


Diffs
-----

  filters/flow/visio/import/CMakeLists.txt faa6767 
  filters/flow/visio/import/flow_vsdx_import.desktop e18e46d 
  filters/karbon/eps/CMakeLists.txt afec470 
  filters/karbon/eps/karbon_eps_import.desktop c5c2cf4 
  filters/karbon/eps/karbon_ps_import.desktop 59b3b34 
  filters/karbon/image/CMakeLists.txt 18bd35c 
  filters/karbon/image/karbon_jpg_export.desktop 14e9e81 
  filters/karbon/image/karbon_png_export.desktop e9acb75 
  filters/karbon/karbon1.x/CMakeLists.txt 1b3bda9 
  filters/karbon/karbon1.x/karbon_1x_import.desktop 235f84b 
  filters/karbon/pdf/CMakeLists.txt 3dd71c2 
  filters/karbon/pdf/karbon_pdf_import.desktop b756597 
  filters/karbon/svg/CMakeLists.txt 789ceaf 
  filters/karbon/svg/karbon_svg_export.desktop 4486896 
  filters/karbon/svg/karbon_svg_import.desktop 558adda 
  filters/karbon/svg/karbon_svgz_import.desktop 4d51801 
  filters/karbon/wmf/CMakeLists.txt 9282735 
  filters/karbon/wmf/karbon_wmf_export.desktop 548b2f3 
  filters/karbon/wmf/karbon_wmf_import.desktop 7ee57ea 
  filters/karbon/wpg/CMakeLists.txt fee395f 
  filters/karbon/wpg/karbon_wpg_import.desktop 53c6023 
  filters/karbon/xfig/CMakeLists.txt aa39b5f 
  filters/karbon/xfig/karbon_xfig_import.desktop 41b7acf 
  filters/plan/mpxj/import/CMakeLists.txt 49dcf0f 
  filters/plan/mpxj/import/plan_msproject_import.desktop 98b4d3b 
  filters/plan/mpxj/import/plan_msprojectexchange_import.desktop d0da3b4 
  filters/plan/mpxj/import/plan_planner_import.desktop 34a25bb 
  filters/sheets/applixspread/CMakeLists.txt 49a44d8 
  filters/sheets/applixspread/kspread_applixspread_import.desktop ef2fedf 
  filters/sheets/csv/CMakeLists.txt faa5b5f 
  filters/sheets/csv/kspread_csv_export.desktop 0f74103 
  filters/sheets/csv/kspread_csv_import.desktop 4a821a8 
  filters/sheets/dbase/CMakeLists.txt 80655ba 
  filters/sheets/dbase/kspread_dbase_import.desktop 5ed981d 
  filters/sheets/excel/export/CMakeLists.txt 5b5aac3 
  filters/sheets/excel/export/kspread_excel_export.desktop e7b3eb7 
  filters/sheets/excel/import/CMakeLists.txt 496e113 
  filters/sheets/excel/import/kspread_excel_import.desktop 3e499c1 
  filters/sheets/gnumeric/CMakeLists.txt a3215e3 
  filters/sheets/gnumeric/kspread_gnumeric_export.desktop a6f68af 
  filters/sheets/gnumeric/kspread_gnumeric_import.desktop 0680a3d 
  filters/sheets/html/CMakeLists.txt 84ae42d 
  filters/sheets/html/kspread_html_export.desktop e325fe7 
  filters/sheets/html/kspread_html_import.desktop ce1334f 
  filters/sheets/latex/export/CMakeLists.txt e154a63 
  filters/sheets/latex/export/kspread_latex_export.desktop b3aa715 
  filters/sheets/opencalc/CMakeLists.txt b850b82 
  filters/sheets/opencalc/kspread_opencalc_export.desktop 72abb3d 
  filters/sheets/opencalc/kspread_opencalc_import.desktop 70d215d 
  filters/sheets/qpro/CMakeLists.txt 0807f95 
  filters/sheets/qpro/kspread_qpro_import.desktop a81bc9f 
  filters/sheets/xlsx/CMakeLists.txt a8fae9a 
  filters/sheets/xlsx/kspread_xlsx_import.desktop 7ad3f33 
  filters/stage/kpr2odf/CMakeLists.txt fe24e5c 
  filters/stage/kpr2odf/Filterkpr2odf.desktop 134c0c2 
  filters/stage/powerpoint/CMakeLists.txt 55c2080 
  filters/stage/powerpoint/kpresenter_powerpoint_import.desktop e2deba3 
  filters/stage/pptx/CMakeLists.txt 85642f8 
  filters/stage/pptx/kpresenter_pptx_import.desktop 00d1128 
  filters/words/applixword/CMakeLists.txt 242a0d7 
  filters/words/applixword/words_applixword_import.desktop db65669 
  filters/words/ascii/CMakeLists.txt 78655f9 
  filters/words/ascii/words_ascii_export.desktop 35a2222 
  filters/words/ascii/words_ascii_import.desktop 3aeed8e 
  filters/words/docx/import/CMakeLists.txt aff322c 
  filters/words/docx/import/words_docx_import.desktop e3384ad 
  filters/words/epub/CMakeLists.txt f281c46 
  filters/words/epub/words_epub2_export.desktop d48e543 
  filters/words/epub/words_html_export.desktop 7ddb19b 
  filters/words/mobi/CMakeLists.txt f7e064f 
  filters/words/mobi/words_Mobi_export.desktop 2ee7f8b 
  filters/words/msword-odf/CMakeLists.txt f903f75 
  filters/words/msword-odf/words_msword-odf_import.desktop 132397f 
  filters/words/rtf/import/CMakeLists.txt d1ac6b1 
  filters/words/rtf/import/words_rtf_import.desktop 3f2daed 
  filters/words/wordperfect/import/CMakeLists.txt c919657 
  filters/words/wordperfect/import/words_wpd_import.desktop e46fbae 
  filters/words/works/import/CMakeLists.txt 2ada91b 
  filters/words/works/import/words_wps_import.desktop 27b4021 

Diff: http://git.reviewboard.kde.org/r/111031/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130625/1385c197/attachment.htm>