Review Request 110624: Epub generation improvement (new metadata)

[Jérémy BOURDIOL]

> On May 30, 2013, 8:06 p.m., Elvis Stansvik wrote:
> > filters/words/epub/EpubFile.cpp, line 259
> > <http://git.reviewboard.kde.org/r/110624/diff/2/?file=147132#file147132line259>
> >
> >     could put a break; after this line.

It is not realy important because it turns to be the last info, but anyway less operations is always a good idea for future.
Now fixed with the little last patch of this feature.


- Jérémy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110624/#review33472
-----------------------------------------------------------


On June 25, 2013, 8:17 p.m., Jérémy BOURDIOL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110624/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 8:17 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> A little improvement of Epub export with new metadata like author and subjects.
> 
> 
> Diffs
> -----
> 
>   filters/words/epub/EpubFile.cpp a946959 
>   filters/words/epub/exportepub2.cpp f00160d 
> 
> Diff: http://git.reviewboard.kde.org/r/110624/diff/
> 
> 
> Testing
> -------
> 
> The generated Epud is tested on Callibre to know if metadata are readable
> It's also checked with http://validator.idpf.org/
> 
> Here is an error occuring when there is no cover image, not of my fate, that's it in master (as i'm writting):
> (ERROR	OEBPS/toc.ncx	14	11	element "navMap" incomplete; missing required element "navPoint")
> 
> 
> Thanks,
> 
> Jérémy BOURDIOL
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130625/ffce9211/attachment.htm>