Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc
Inge Wallin
inge at lysator.liu.se
Sun Jun 23 04:15:00 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110821/#review34895
-----------------------------------------------------------
I think it's very difficult to give any form of review for this since you're the only one who knows these parts of the code. Or? Could you give an overview of how these parts are designed to work together?
- Inge Wallin
On June 3, 2013, 6:05 p.m., C. Boemann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110821/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 6:05 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> This is still work in progress, but I need to view it here and possibly get someone else to take a look as well
>
>
> Diffs
> -----
>
> libs/kotext/commands/TextPasteCommand.h 77d710a
> libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 044fd27
> libs/kotext/KoTextPaste.cpp 2304d6a
> libs/kotext/KoTextPaste.h 522ccce
> libs/kotext/KoTextEditor.cpp 1a88757
> libs/kotext/KoTextEditor.h 9fd3c05
> libs/flake/KoToolProxy.cpp 80081c6
> libs/flake/KoShapeAnchor.cpp 83087c3
> libs/flake/KoShapePaste.cpp 1457daf
> libs/kotext/commands/TextPasteCommand.cpp 34ea25c
> libs/kotext/opendocument/KoTextLoader.cpp 7831109
> libs/kotext/opendocument/KoTextSharedLoadingData.h 5ebb7a1
> libs/kotext/opendocument/KoTextSharedLoadingData.cpp d9a73e9
> plugins/defaultTools/defaulttool/DefaultTool.cpp 6a19185
> plugins/textshape/TextTool.cpp 37ba52e
> words/part/KWDocument.cpp 57aba26
>
> Diff: http://git.reviewboard.kde.org/r/110821/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> C. Boemann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130623/123a9a16/attachment.htm>
More information about the calligra-devel
mailing list