Review Request 111168: Use separate tags for all resource types to prevent tag overlap.
Commit Hook
null at kde.org
Sat Jun 22 15:11:15 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111168/#review34875
-----------------------------------------------------------
This review has been submitted with commit f96a2bfd7c4e85be94e01a29549f106f3702776f by Sascha Suelzer to branch master.
- Commit Hook
On June 22, 2013, 8:17 a.m., Sascha Suelzer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111168/
> -----------------------------------------------------------
>
> (Updated June 22, 2013, 8:17 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Using a shared tag file for all resources causes a tagging overlap if the resource types have a file extension in common.
> PNGs, for example, are used by patterns and predefined brush shapes and tagging patterns with a PNG extension would make the tag show up in the predefined brushes, as well, but without listing the resources, since they are of a different type.
>
> Using separate tag files fixes this issue.
>
>
> Diffs
> -----
>
> libs/widgets/KoResourceServer.h 82c8d6a
> libs/widgets/KoResourceTagging.h d89126a
> libs/widgets/KoResourceTagging.cpp 08567dc
>
> Diff: http://git.reviewboard.kde.org/r/111168/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sascha Suelzer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130622/a5056f69/attachment.htm>
More information about the calligra-devel
mailing list