Review Request 111153: Replace Add and Remove tag buttons for KoResourceItemChooser tag combo box with QToolButton
Sascha Suelzer
s_suelzer at lavabit.com
Fri Jun 21 15:40:38 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111153/
-----------------------------------------------------------
(Updated June 21, 2013, 2:40 p.m.)
Review request for Calligra.
Changes
-------
Jump to renamed tag correctly.
This time with a nicer fix.
This RR is mainly for checking the new functionality. The code is meant to be (and will be) refactored into its own widget and everything.
I'm doing the two steps separately to keep the diff manageable.
Description
-------
Replaces the Add and Remove tag buttons for KoResourceItemChooser tag combo box with a QToolButton that shows a nice menu for top level tag management.
Implements renaming of a tag.
Implements undeleting the last deleted tag and an option to clear an active undeletion option, for the cases where the user is really sure about removing a tag.
Diffs (updated)
-----
libs/widgets/KoResourceItemChooser.h d5a6583
libs/widgets/KoResourceItemChooser.cpp dc0838b
libs/widgets/KoResourceItemChooserContextMenu.h f049052
libs/widgets/KoResourceItemChooserContextMenu.cpp a41648b
libs/widgets/KoResourceModel.h 2cbf411
libs/widgets/KoResourceModel.cpp 1503da1
libs/widgets/KoResourceServerAdapter.h 6278f30
Diff: http://git.reviewboard.kde.org/r/111153/diff/
Testing
-------
Standard tests. Krita only.
Thanks,
Sascha Suelzer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130621/807de882/attachment.htm>
More information about the calligra-devel
mailing list