Review Request 111147: Rename KoCanvasResourceManager::resourceChanged

C. Boemann cbr at boemann.dk
Thu Jun 20 10:20:59 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111147/#review34739
-----------------------------------------------------------

Ship it!


Ship It!

- C. Boemann


On June 20, 2013, 8:53 a.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111147/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 8:53 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> We have a bunch of signals all called "resourceChanged". This patch renames KoCanvasResourceManager::resourceChanged to KoCanvasResourceManager::canvasResourceChanged, to make it easier to grep and find all places where we connect to that signal.
> 
> Plan::Project::resourceChanged
> KoAbstractResourceServerAdapter::resourceChanged
> KoDocumentResourceManager::resourceChanged
> 
> are the other places (that I know of).
> 
> 
> Diffs
> -----
> 
>   karbon/ui/KarbonZoomController.h 8a82f96 
>   karbon/ui/KarbonZoomController.cpp 0b82f50 
>   krita/image/kis_default_bounds.h d51124b 
>   krita/image/kis_layer.cc 96b7216 
>   krita/image/kis_paint_device.cc 4b1f6c3 
>   krita/image/kis_paint_layer.cc 4494309 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.h ca4e759 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.cpp 774a30e 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_minimal_shade_selector.h 0e996dd 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_minimal_shade_selector.cpp 6d88766 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_my_paint_shade_selector.h d6b65d8 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_my_paint_shade_selector.cpp 7401846 
>   krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.h 8fbe831 
>   krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.cpp 0376183 
>   krita/plugins/extensions/dockers/digitalmixer/digitalmixer_dock.h 11d9ff4 
>   krita/plugins/extensions/dockers/digitalmixer/digitalmixer_dock.cc f9466f4 
>   krita/plugins/extensions/dockers/smallcolorselector/smallcolorselector_dock.h b0badb6 
>   krita/plugins/extensions/dockers/smallcolorselector/smallcolorselector_dock.cc 9965225 
>   krita/plugins/tools/tool_crop/kis_tool_crop.h 7e835d1 
>   krita/plugins/tools/tool_crop/kis_tool_crop.cc 7e49d5d 
>   krita/ui/kis_canvas_resource_provider.h 61a0ec8 
>   krita/ui/kis_canvas_resource_provider.cpp a328ab1 
>   krita/ui/tool/kis_tool.h 565a60f 
>   krita/ui/tool/kis_tool.cc 511221c 
>   krita/ui/tool/kis_tool_freehand_helper.cpp 03c28fc 
>   krita/ui/tool/kis_tool_paint.h d2174b8 
>   krita/ui/tool/kis_tool_paint.cc ac5ae96 
>   krita/ui/widgets/kis_filter_selector_widget.cc 2dbad35 
>   krita/ui/widgets/kis_scratch_pad.cpp aa62626 
>   libs/flake/KoCanvasResourceManager.h d396a58 
>   libs/flake/KoCanvasResourceManager.cpp 1a91afa 
>   libs/flake/KoToolBase.h 65777d1 
>   libs/flake/KoToolBase.cpp c35e076 
>   libs/flake/KoToolBase_p.h 624fa86 
>   libs/flake/tests/TestResourceManager.cpp bac9a3f 
>   libs/kotext/KoFind.h 4b16355 
>   libs/kotext/KoFind.cpp 0ec57f3 
>   libs/main/KoRulerController.cpp 26a4cd7 
>   libs/widgets/KoStrokeConfigWidget.h 7eec2a4 
>   libs/widgets/KoStrokeConfigWidget.cpp 105e3f7 
>   plugins/defaultTools/defaulttool/DefaultTool.h 18aac59 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp 6a19185 
>   plugins/defaultTools/defaulttool/DefaultToolTransformWidget.cpp a5e8069 
>   plugins/defaultTools/defaulttool/DefaultToolWidget.cpp 0e5eb1f 
>   plugins/defaultTools/guidestool/GuidesTool.h 0f9afec 
>   plugins/defaultTools/guidestool/GuidesTool.cpp 6058866 
>   plugins/dockers/shapeproperties/ShapePropertiesDocker.h 4f422b2 
>   plugins/dockers/shapeproperties/ShapePropertiesDocker.cpp 507fa89 
>   plugins/dockers/styledocker/StyleDocker.h 13cf77f 
>   plugins/dockers/styledocker/StyleDocker.cpp ffec9c4 
>   plugins/textshape/TextTool.h b5ad2e0 
>   plugins/textshape/TextTool.cpp 37ba52e 
>   words/part/KWStatusBar.h 1644f27 
>   words/part/KWStatusBar.cpp 34cd834 
>   words/part/dockers/KWRdfDocker.h 5d253b7 
>   words/part/dockers/KWRdfDocker.cpp 84e63d7 
> 
> Diff: http://git.reviewboard.kde.org/r/111147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130620/259a47c2/attachment.htm>


More information about the calligra-devel mailing list