Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class
Commit Hook
null at kde.org
Sun Jun 16 18:47:41 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110910/
-----------------------------------------------------------
(Updated June 16, 2013, 5:47 p.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra.
Description
-------
Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class, any style feedback is welcome.
Also a tiny amount of whitespace cleanup, but only for the files affected by the code changes.
Diffs
-----
libs/widgets/KoResourceItemChooser.h 29fb09a
libs/widgets/KoResourceItemChooser.cpp 4ae16ad
libs/widgets/KoResourceItemChooserContextMenu.h a33a132
libs/widgets/KoResourceItemChooserContextMenu.cpp 6af2fe1
Diff: http://git.reviewboard.kde.org/r/110910/diff/
Testing
-------
Tested only for Krita, everything seems to work as it should.
Thanks,
Sascha Suelzer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130616/c3e65bec/attachment.htm>
More information about the calligra-devel
mailing list