Review Request 111044: Implement borders for shapes

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111044/#review34410
-----------------------------------------------------------



libs/odf/KoBorder.cpp
<http://git.reviewboard.kde.org/r/111044/#comment25276>

    you should scale the painter rather than having zoomAcross and zoomalong, otherwise the line pattern will not scale correctly



libs/odf/KoBorder.cpp
<http://git.reviewboard.kde.org/r/111044/#comment25275>

    see KoTableCellStyle::setEdge
    
    for how to do this correctly
    
    mind you we build the pen once and keep it so we don't have to rebuild a pen everytime we paint, which for tablecells at least can be quite costly. In fact borderdate is the struct that holds these pens



libs/odf/KoBorder.cpp
<http://git.reviewboard.kde.org/r/111044/#comment25277>

    you know this is one of those places where using style stack to resolve inheritance will yield wrong results
    
    That said it's ofcourse an improvement over not handling inheritance at all



libs/odf/KoBorder.cpp
<http://git.reviewboard.kde.org/r/111044/#comment25278>

    in particular this else should not be there but i'm not sure removing it is enough, because on one level only i belive border has precedence over border-xyz



libs/odf/KoBorder.cpp
<http://git.reviewboard.kde.org/r/111044/#comment25279>

    same about this else


- C. Boemann


On June 15, 2013, 6:35 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111044/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 6:35 p.m.)
> 
> 
> Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> This patch implements loading, saving and painting of borders for shapes in general. It also implements calls to actually paint borders in particular for the picture shape and text shape.
> 
> At the same time I moved border painting from KWCanvasBase to KoBorder, which I announced some weeks ago that I wanted to do.
> 
> A patch this deep in the libraries should not go in without a run of cstester. I would be glad for help with this since I only have a semi-weak laptop.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.h fe6cc3f 
>   libs/flake/KoShape.cpp 6d14a8c 
>   libs/flake/KoShape_p.h aa6633c 
>   libs/odf/KoBorder.h bdbf86e 
>   libs/odf/KoBorder.cpp 58f8e45 
>   plugins/pictureshape/PictureShape.cpp 976fadd 
>   plugins/textshape/TextShape.cpp b230f0a 
>   words/part/KWCanvasBase.cpp 7d12890 
> 
> Diff: http://git.reviewboard.kde.org/r/111044/diff/
> 
> 
> Testing
> -------
> 
> Tested with all the files with the string "border" in it in the test suite.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130616/bcc49f63/attachment.htm>