Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class

[Sascha Suelzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110910/
-----------------------------------------------------------

(Updated June 12, 2013, 8:01 p.m.)


Review request for Calligra.


Changes
-------

Changed context menu initialization to building the context menu right in the constructor.
Setters that were previously used to prepare the delayed construction with exec(position) have been turned into constructor arguments.

Thanks, Friedrich W. H. Kossebau, for the suggestion (and reminding of the good practice to only write code for present use cases, not for planned things in the future ;) ). 


Description
-------

Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class, any style feedback is welcome.
Also a tiny amount of whitespace cleanup, but only for the files affected by the code changes.


Diffs (updated)
-----

  libs/widgets/KoResourceItemChooser.h 29fb09a 
  libs/widgets/KoResourceItemChooser.cpp 4ae16ad 
  libs/widgets/KoResourceItemChooserContextMenu.h a33a132 
  libs/widgets/KoResourceItemChooserContextMenu.cpp 6af2fe1 

Diff: http://git.reviewboard.kde.org/r/110910/diff/


Testing
-------

Tested only for Krita, everything seems to work as it should.


Thanks,

Sascha Suelzer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130612/2e26b0c8/attachment.htm>