Review Request 110928: Always save the position of a shape
Inge Wallin
inge at lysator.liu.se
Mon Jun 10 20:18:38 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110928/
-----------------------------------------------------------
(Updated June 10, 2013, 7:18 p.m.)
Review request for Calligra.
Changes
-------
Updated the description to be less ambiguous.
Description (updated)
-------
When a shape is in the position 0, 0 and there are no other transformations, the position will not be saved back. In other words, there will be an svg:height and svg:width but no svg:x or svg:y. I noticed this while trying to fix https://bugs.kde.org/show_bug.cgi?id=184727.
This patch fixes that the code doesn't save the position. I suggest that we apply it to 2.7 as well and maybe also to 2.6.
Diffs
-----
libs/flake/KoShape.cpp 6d14a8c
Diff: http://git.reviewboard.kde.org/r/110928/diff/
Testing
-------
Tested with the file mentioned above.
Thanks,
Inge Wallin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130610/05dc6909/attachment.htm>
More information about the calligra-devel
mailing list