Review Request 110928: Always save the position of a shape
C. Boemann
cbr at boemann.dk
Mon Jun 10 18:52:38 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110928/#review34071
-----------------------------------------------------------
I still don't see the relation to the bug nor do I understand why we need to save 0,0
- C. Boemann
On June 10, 2013, 5:37 p.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110928/
> -----------------------------------------------------------
>
> (Updated June 10, 2013, 5:37 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> When a shape is in the position 0, 0 and there are no other transformations, the position will not be saved back. In other words, there will be an svg:height and svg:width but no svg:x or svg:y. I noticed this while trying to fix https://bugs.kde.org/show_bug.cgi?id=184727.
>
> This patch fixes this bug. I suggest that we apply it to 2.7 as well and maybe also to 2.6.
>
>
> Diffs
> -----
>
> libs/flake/KoShape.cpp 6d14a8c
>
> Diff: http://git.reviewboard.kde.org/r/110928/diff/
>
>
> Testing
> -------
>
> Tested with the file mentioned above.
>
>
> Thanks,
>
> Inge Wallin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130610/ec6c4754/attachment.htm>
More information about the calligra-devel
mailing list