Calligra 2.7 release blockers

[Cyrille Berger]

On 2013-06-09 20:38, Elvis Stansvik wrote:
> 2013/6/9 Cyrille Berger Skott <cberger at cberger.net>
> 
>> On Sunday 09 Jun 2013, Boudewijn Rempt wrote:
>>> On Thursday 30 May 2013 May 14:57:04 Cyrille Berger wrote:
>>> > Hi,
>>> >
>>> > Don't forget to mark the bugs that are release blocker as such
>> in
>>> > bugs.kde.org [1], currently there are four release blockers:
>>> >
>>> > https://bugs.kde.org/show_bug.cgi?id=318724 [2] "Opening a
>> specific JPEG
>>> > asserts Krita"
>>> 
>>> This is because distributions are starting to move to libjpeg8,
>> dropping
>>> turbo. I've added a warning to cmake, but I'm not sure how to
>> disable
>>> building the jpeg plugin when only jpeg8 is present, nor how to
>> fix the
>>> jpeg plugin to work properly with jpeg8.
>> 
>> Ok, I will try to come with a patch for the metadata bit, as for
>> jpeg8, I
>> guess checking if the library name contains the digit 8 with a
>> regexp in the
>> cmakelists.txt should do the trick (8 or 9 since jpeg9 is worse
>> than
>> anything).
> 
> Hm. I have:
> 
> /usr/lib/libjpeg.so
> /usr/lib/libjpeg.so.8
> /usr/lib/libjpeg.so.8.0.2
> 
>  These are installed by the libjpeg-turbo package on Arch. And I can
> open both files in the bug report fine.
> 
> Perhaps I'm misunderstanding, but wouldn't such a check disable
> compilation for me then?

Good point. Anyway something like this would be better (untested):

file(READ ${JPEG_INCLUDE_DIR}/jpeglib.h JPEGLIB_CONTENT)
string(REGEX MATCH "#define JCS_EXTENSIONS 1\n" JPEG_HAS_JCS_EXTENSIONS)
if(JPEG_HAS_JCS_EXTENSIONS)
   message(STATUS "Found jpegturbo everything is fine.")
else()
   message(STATUS "Found broken IJG JPEG, disabling JPEG format in 
Krita")
endif()

(And I will suggest to disable Krita as a whole to avoid silly review 
such as "Krita does not even support jpeg")

It is also possible to do do a runtime detection:

  
ttp://sourceforge.net/p/libjpeg-turbo/discussion/1086868/thread/48194813

-- 
Cyrille Berger Skott