Review Request 111734: add test for ppt conversion

Matus Uzak matus.uzak at ixonos.com
Sat Jul 27 17:21:31 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111734/#review36608
-----------------------------------------------------------


Hello Jos, don't you like runtests.sh any more? ;)

The approach you suggested requires to commit new files from the ODP archive after most changes in the filter or libmso (not diagram specific).

If you want to check the diagram representation, then it's easier to write a simple XSL template which checks exactly that by a call to corresponding template from sharedtemplates.xsl.  I'm used to create at least MS Powerpoint 2000 and 2003 versions of a document to fine tune the filter to generate same representation of a diagram.  Check the calligratests/import/powerpoint/ directory for examples.  And there is a pair of PPT files containing a diagram in interoperability/presentations/, prepared by Wipro.  It's required to merge the content of ppt_2000 and ppt_2003 directories to apply a single XSL template to both filter outputs.

URL: svn+ssh://svn@svn.kde.org/home/kde/trunk/tests/calligratests/

|-interoperability/presentations/
|-import/powerpoint/
|-import/share/bin/runtests.sh
|-import/share/xsl/sharedtemplates.xsl

- Matus Uzak


On July 26, 2013, 8:41 p.m., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111734/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 8:41 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> To test ppt conversion the simplest approach is to take a ppt file, convert it to odp and check that the output is exactly the same.
> This test does that for a simple two slide presentation with a diagram.
> 
> 
> Diffs
> -----
> 
>   filters/stage/powerpoint/CMakeLists.txt b434bef 
>   filters/stage/powerpoint/tests/CMakeLists.txt PRE-CREATION 
>   filters/stage/powerpoint/tests/TestPPT.h PRE-CREATION 
>   filters/stage/powerpoint/tests/TestPPT.cpp PRE-CREATION 
>   filters/stage/powerpoint/tests/data/diagram.ppt PRE-CREATION 
>   filters/stage/powerpoint/tests/data/diagram_odp/META-INF/manifest.xml PRE-CREATION 
>   filters/stage/powerpoint/tests/data/diagram_odp/content.xml PRE-CREATION 
>   filters/stage/powerpoint/tests/data/diagram_odp/meta.xml PRE-CREATION 
>   filters/stage/powerpoint/tests/data/diagram_odp/settings.xml PRE-CREATION 
>   filters/stage/powerpoint/tests/data/diagram_odp/styles.xml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111734/diff/
> 
> 
> Testing
> -------
> 
> Ran the test multiple times and it passes every time. It is repeatable.
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130727/6525e27f/attachment.htm>


More information about the calligra-devel mailing list