Review Request 111703: Link calligrakdgantt only against Qt libs, not KDE4_KDECORE_LIBS
Inge Wallin
inge at lysator.liu.se
Fri Jul 26 14:11:17 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111703/#review36548
-----------------------------------------------------------
Ship it!
No, as far as I know both the KDAB libraries are Qt only. So just push it.
- Inge Wallin
On July 25, 2013, 9:47 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111703/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 9:47 p.m.)
>
>
> Review request for Calligra and Inge Wallin.
>
>
> Description
> -------
>
> Is there a reason to link calligrakdgantt against KDE4_KDECORE_LIBS? For me everythings links fine with just Qt libs as deps.
>
>
> Diffs
> -----
>
> 3rdparty/kdgantt/CMakeLists.txt 70bccb5
>
> Diff: http://git.reviewboard.kde.org/r/111703/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130726/5ab8b32c/attachment.htm>
More information about the calligra-devel
mailing list