Review Request 111411: Remove outdated kchartpart.desktop, there is no longer a kchartpart module
Commit Hook
null at kde.org
Tue Jul 23 10:22:38 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111411/#review36345
-----------------------------------------------------------
This review has been submitted with commit a27caa2b7a1a75afe55acb9eb25358e575758ac4 by Friedrich W. H. Kossebau to branch calligra/2.7.
- Commit Hook
On July 23, 2013, 9:18 a.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111411/
> -----------------------------------------------------------
>
> (Updated July 23, 2013, 9:18 a.m.)
>
>
> Review request for Calligra, C. Boemann and Inge Wallin.
>
>
> Description
> -------
>
> kchartpart.desktop refers to
> X-KDE-Library=kchartpart
> but I could not find any rules to build such a module.
> Was that lost or removed on purpose? If the latter then this patch cleans up and removes this desktop file as well.
>
> There is a class ChartPart : public KoPart in ChartPart.h which is used by ChartDocument.cpp to create the part for the ChartDocument. But it seems just a dummy these days, right?
>
> Okay to backport to 2.7?
>
>
> Diffs
> -----
>
> plugins/chartshape/kchartpart.desktop cb7e23f
> plugins/chartshape/CMakeLists.txt 896a723
>
> Diff: http://git.reviewboard.kde.org/r/111411/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130723/a3ce3387/attachment.htm>
More information about the calligra-devel
mailing list