Review Request 111413: Plan - Set First Day of Week to Monday if using ISO Week for week numbering

[Friedrich W. H. Kossebau]

> On July 18, 2013, 10:21 p.m., Alvaro Soliverez wrote:
> > Any update on this? I'd like to see it included in the next beta if possible

Sorry, did not yet manage to schedule time for this (due to Akademy etc.). Still want to give this some more investigations to countercheck and understand what is the problem and how you solved it (to make this a real review ;) ). Next week I should have more time for that. Too late for 2.7.0 possibly, but 2.7.1 is a safe target.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111413/#review36143
-----------------------------------------------------------


On July 6, 2013, 12:51 a.m., Alvaro Soliverez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111413/
> -----------------------------------------------------------
> 
> (Updated July 6, 2013, 12:51 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Plan uses week numbering extensively. The default week numbering in KDE is ISO Week, which uses Monday as first day of the week, regardless of other locale settings.
> 
> To make it consistent through the application, if week numbering format is ISO Week, set the first day of the week to Monday, and display it accordingly in charts and graphs.
> 
> Without this patch, the week could be set to start on Sunday, and week would be shown on graphs as ranging from Sunday to Saturday, but the week number of working days would be off by one.
> 
> Example: 
> 
> - Week numbering: ISO Week
> - First day of week: Sunday
> 
> Without patch:
> - Week displayed: 2013-07-07 to 2013-07-13
> - Week number shown on charts: 27
> 
> - Expected week number: 28 (Week 27 ends on Sunday 2013-07-07)
> 
> With patch:
> - Week displayed: 2013-07-08 to 2013-07-14
> - Week number shown on charts: 28
> 
> 
> Additionally, there were a few calls to QDate::week() to get the week number, instead of using KGlobalCalendar.
> 
> 
> This addresses bug 321290.
>     http://bugs.kde.org/show_bug.cgi?id=321290
> 
> 
> Diffs
> -----
> 
>   plan/libs/ui/kptganttview.cpp 81073a3 
>   plan/libs/models/kptaccountsmodel.cpp 71c3100 
>   plan/libs/models/kcalendar/kdatetable.cpp b389345 
>   3rdparty/kdgantt/kdganttdatetimegrid.cpp 79c405c 
> 
> Diff: http://git.reviewboard.kde.org/r/111413/diff/
> 
> 
> Testing
> -------
> 
> Tested on a live file. It displays calendars and gantt charts correctly.
> 
> 
> Thanks,
> 
> Alvaro Soliverez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130719/5d443b53/attachment.htm>