Review Request 109994: New implementation for handling formulas

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109994/#review35611
-----------------------------------------------------------


Hi Gopalakrishna.
Sorry for taking so long to review this, somehow I missed that there was a new version.  Anyway, I have built the branch now and tested it.  

There is something strange going on here. I created a couple of very simple formulas in LibreOffice and then loaded that file. I don't see the rendered formulas but I do see the LO math language, so probably you are loading the wrong part of the formula into the widget.  Did you test the new shape only with formulas that were created in Calligra?  LO creates some annotation in MathML with the formulas themselves, which Calligra doesn't do, so it could be something like that.

- Inge Wallin


On April 19, 2013, 2:25 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109994/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 2:25 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This new implementation for formulashape uses and improves on qtmmlwidgets that was part of Qt Solutions. The code can be found in plugins-formulashape2g-gopalK branch.
> 
> Currently implemented features are
> 1) Loading of formulas in document.
> 2) Insert of MathML formulas generated from some other tools(viz FireMath plugin for Firefox)
> 3) Editing of existing formulas.
> 
> Features that were there in old version of formulashape but missing now
> 1) Insert of Elements, Symbols (in a very much unusable state)
> 2) Edit formulas with LaTeX syntax (Will be done in coming days)
> 
> I will remove the extra whitespace that exists in the uploaded diff before merging :)
> 
> 
> Diffs
> -----
> 
>   plugins/staging/CMakeLists.txt 754362f 
>   plugins/staging/formulashape-2g/AlterFormulaCommand.h PRE-CREATION 
>   plugins/staging/formulashape-2g/AlterFormulaCommand.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/CMakeLists.txt PRE-CREATION 
>   plugins/staging/formulashape-2g/ChangeFormulaCommand.h PRE-CREATION 
>   plugins/staging/formulashape-2g/ChangeFormulaCommand.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaCursor.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaCursor.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaDocument.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaDocument.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaPart.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaPart.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShape.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShape.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShapeFactory.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShapeFactory.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShapePlugin.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShapePlugin.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaTool.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaTool.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaToolFactory.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaToolFactory.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/Messages.sh PRE-CREATION 
>   plugins/staging/formulashape-2g/formula_export.h PRE-CREATION 
>   plugins/staging/formulashape-2g/formulashape2g.desktop PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/LGPL_EXCEPTION.txt PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/LICENSE.GPL3 PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/LICENSE.LGPL PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/QtMmlDocument PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/QtMmlWidget PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/README.TXT PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/qtmmlwidget.h PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/qtmmlwidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109994/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Snapshot
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/formulaShape.png
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130705/8401dcb4/attachment.htm>