Review Request 111153: Replace Add and Remove tag buttons for KoResourceItemChooser tag combo box with QToolButton
Boudewijn Rempt
boud at valdyas.org
Thu Jul 4 09:05:14 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111153/#review35556
-----------------------------------------------------------
Ship it!
Looks and works fine.
- Boudewijn Rempt
On July 4, 2013, 6:40 a.m., Sascha Suelzer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111153/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 6:40 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Replaces the Add and Remove tag buttons for KoResourceItemChooser tag combo box with a QToolButton that shows a nice menu for top level tag management.
> Implements renaming of a tag.
> Implements undeleting the last deleted tag and an option to clear an active undeletion option, for the cases where the user is really sure about removing a tag.
>
>
> Diffs
> -----
>
> libs/widgets/KoResourceItemChooser.h d5a6583
> libs/widgets/KoResourceItemChooser.cpp 8af7eee
> libs/widgets/KoResourceItemChooserContextMenu.h f049052
> libs/widgets/KoResourceItemChooserContextMenu.cpp a41648b
> libs/widgets/KoResourceModel.h 2cbf411
> libs/widgets/KoResourceModel.cpp 1503da1
> libs/widgets/KoResourceServerAdapter.h 6278f30
>
> Diff: http://git.reviewboard.kde.org/r/111153/diff/
>
>
> Testing
> -------
>
> Standard tests. Krita only.
>
>
> Thanks,
>
> Sascha Suelzer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130704/64a3bf82/attachment.htm>
More information about the calligra-devel
mailing list