Review Request 111363: Make loading of colors in colorsets more tolerant to bogus values

Boudewijn Rempt boud at valdyas.org
Tue Jul 2 15:38:57 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111363/#review35445
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On July 2, 2013, 2:37 p.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111363/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 2:37 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> In the .gpl colorset files it might happen that an application save a value like 256, which is out of bounds. In that case the values is now set to 255, instead of aborting the loading.
> 
> 
> This addresses bug 318345.
>     http://bugs.kde.org/show_bug.cgi?id=318345
> 
> 
> Diffs
> -----
> 
>   libs/pigment/resources/KoColorSet.h eb28db0 
>   libs/pigment/resources/KoColorSet.cpp 2367631 
> 
> Diff: http://git.reviewboard.kde.org/r/111363/diff/
> 
> 
> Testing
> -------
> 
> Tested in Krita.
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130702/a4ea477a/attachment.htm>


More information about the calligra-devel mailing list