Review Request 108684: Move palettes to a Calligra-wide data folder

[C. Boemann]

> On Jan. 31, 2013, 10:21 p.m., Jarosław Staniek wrote:
> > What if we only install Plan or Kexi? Are the palettes needed?
> 
> C. Boemann wrote:
>     well if it's not used in kexi and plan I would say it's a missing feature in those apps. Whenever the user chooses color for anything (text or backround color) then the KoColorPopupAction should really be used and that takes advantage of any installed palettes.
> 
> Jarosław Staniek wrote:
>     Ah, then then things like KoColorPopupAction shall go to libs/widgetutils, i.e. to a kotext-independent place I guess.
>

yes that would make sense, I'm not toally sure it doesn't depend on something that depends on something else though


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108684/#review26478
-----------------------------------------------------------


On Jan. 31, 2013, 2:16 p.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108684/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2013, 2:16 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Moves the palettes from Krita to calligra/data. That makes sure that they will always be installed even if Krita is not installed.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a979e27 
>   data/palettes/1-All-Color-for-good-colors-choice.gpl PRE-CREATION 
>   data/palettes/1-classic-kit.gpl PRE-CREATION 
>   data/palettes/CMakeLists.txt PRE-CREATION 
>   data/palettes/Fabric_colored.gpl PRE-CREATION 
>   data/palettes/Fabric_jeans.gpl PRE-CREATION 
>   data/palettes/Human_Hair.gpl PRE-CREATION 
>   data/palettes/Human_Skin.gpl PRE-CREATION 
>   data/palettes/Human_eyes.gpl PRE-CREATION 
>   data/palettes/Human_lips.gpl PRE-CREATION 
>   data/palettes/NESPAL.gpl.gpl PRE-CREATION 
>   data/palettes/Named_Colors.gpl PRE-CREATION 
>   data/palettes/Nature_Grass.gpl PRE-CREATION 
>   data/palettes/Nature_Water_Sky.gpl PRE-CREATION 
>   data/palettes/Nature_flowers.gpl PRE-CREATION 
>   data/palettes/Nature_stones.gpl PRE-CREATION 
>   data/palettes/Nature_wood.gpl PRE-CREATION 
>   data/palettes/Paletilla.gpl PRE-CREATION 
>   data/palettes/Skin.gpl.txt.gpl PRE-CREATION 
>   data/palettes/Untitled.gpl PRE-CREATION 
>   data/palettes/bugslife_final.png-10.gpl PRE-CREATION 
>   data/palettes/color_wheel-2-rgb.aco.gpl PRE-CREATION 
>   data/palettes/mi-paleta-2009.aco.gpl PRE-CREATION 
>   data/palettes/new_kde.gpl PRE-CREATION 
>   data/palettes/photoshop-swatches-sketchlings-swatches.aco.gpl PRE-CREATION 
>   data/palettes/testgimp_swatches.aco.gpl PRE-CREATION 
>   krita/data/CMakeLists.txt 6cd7f8c 
>   krita/data/palettes/1-All-Color-for-good-colors-choice.gpl 0278cae 
>   krita/data/palettes/1-classic-kit.gpl d350705 
>   krita/data/palettes/CMakeLists.txt b6357f2 
>   krita/data/palettes/Fabric_colored.gpl 06ef62a 
>   krita/data/palettes/Fabric_jeans.gpl 320f407 
>   krita/data/palettes/Human_Hair.gpl 2db81a9 
>   krita/data/palettes/Human_Skin.gpl c0270b1 
>   krita/data/palettes/Human_eyes.gpl 93c4c82 
>   krita/data/palettes/Human_lips.gpl db042d4 
>   krita/data/palettes/NESPAL.gpl.gpl 2d402b1 
>   krita/data/palettes/Named_Colors.gpl 5fbd533 
>   krita/data/palettes/Nature_Grass.gpl d42de32 
>   krita/data/palettes/Nature_Water_Sky.gpl 449dfae 
>   krita/data/palettes/Nature_flowers.gpl d8b48ab 
>   krita/data/palettes/Nature_stones.gpl f9db81a 
>   krita/data/palettes/Nature_wood.gpl 75cb7e1 
>   krita/data/palettes/Paletilla.gpl 22de9c9 
>   krita/data/palettes/Skin.gpl.txt.gpl bf5b439 
>   krita/data/palettes/Untitled.gpl 55bfc1c 
>   krita/data/palettes/bugslife_final.png-10.gpl c763da7 
>   krita/data/palettes/color_wheel-2-rgb.aco.gpl e162db4 
>   krita/data/palettes/mi-paleta-2009.aco.gpl 1edac18 
>   krita/data/palettes/new_kde.gpl 3364760 
>   krita/data/palettes/photoshop-swatches-sketchlings-swatches.aco.gpl 2404ac9 
>   krita/data/palettes/testgimp_swatches.aco.gpl 9c6cfb0 
>   libs/widgets/KoResourceServerProvider.cpp 2b95eaa 
> 
> Diff: http://git.reviewboard.kde.org/r/108684/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130131/1b4cd476/attachment.htm>