Review Request 108683: Delete old view before creating a new view

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108683/#review26459
-----------------------------------------------------------


This review has been submitted with commit 48e9e2cc5ccc25aaf630fef52a5ad04c8d0b3e3b by Sven Langkamp to branch master.

- Commit Hook


On Jan. 31, 2013, 11:01 a.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108683/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2013, 11:01 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> When opening a new document the old view is destroyed after the the new view is set. The destructor of old view will call unset canvas, which disconnects the new view from the dockers. For example this causes the layer box in Krita to not show the layers.
> 
> The patch fixes that by deleting the old view before creating the new one.
> 
> 
> This addresses bug 314029.
>     http://bugs.kde.org/show_bug.cgi?id=314029
> 
> 
> Diffs
> -----
> 
>   libs/main/KoMainWindow.cpp 19f91f1 
> 
> Diff: http://git.reviewboard.kde.org/r/108683/diff/
> 
> 
> Testing
> -------
> 
> Tested with Krita.
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130131/a9ba72f1/attachment.htm>