Review Request 108683: Delete old view before creating a new view

Sven Langkamp sven.langkamp at gmail.com
Thu Jan 31 11:01:19 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108683/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

When opening a new document the old view is destroyed after the the new view is set. The destructor of old view will call unset canvas, which disconnects the new view from the dockers. For example this causes the layer box in Krita to not show the layers.

The patch fixes that by deleting the old view before creating the new one.


This addresses bug 314029.
    http://bugs.kde.org/show_bug.cgi?id=314029


Diffs
-----

  libs/main/KoMainWindow.cpp 19f91f1 

Diff: http://git.reviewboard.kde.org/r/108683/diff/


Testing
-------

Tested with Krita.


Thanks,

Sven Langkamp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130131/35396685/attachment.htm>


More information about the calligra-devel mailing list