Review Request 107580: Avoid compiler warning in Global.h for external projects using Sheets' components
Friedrich W. H. Kossebau
kossebau at kde.org
Mon Jan 28 19:16:11 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107580/#review26328
-----------------------------------------------------------
Hi Philip, could you close this request as discarded, as this patch is now obsolete, thanks to your other patch you did, which was committed meanwhile?
See https://projects.kde.org/projects/calligra/repository/revisions/master/entry/sheets/ElapsedTime_p.h#L69
- Friedrich W. H. Kossebau
On Dec. 4, 2012, 2:47 p.m., Philip Hoof wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107580/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2012, 2:47 p.m.)
>
>
> Review request for Calligra and Boudewijn Rempt.
>
>
> Description
> -------
>
> This patch makes Global.h of sheets/ stop using old-style casts, avoiding a compiler warning for projects using Calligra's sheets component.
>
>
> Diffs
> -----
>
> sheets/Global.h 1759095
>
> Diff: http://git.reviewboard.kde.org/r/107580/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Philip Hoof
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130128/33f941b4/attachment.htm>
More information about the calligra-devel
mailing list