Review Request 108586: remove Sheets::Doc::updateBorderButton(), currently endless loop and view-, not doc-related
Friedrich W. H. Kossebau
kossebau at kde.org
Fri Jan 25 23:10:14 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108586/
-----------------------------------------------------------
Review request for Calligra and Marijn Kruisselbrink.
Description
-------
MSVC hinted that there is an endless loop waiting in this method. Right it is! Somehow the method calls itself assuming that a signal exists with the same name.
Seems left-over from part->doc/part split. The related method in SheetAdaptor is still commented out.
Patch simply removes the method. Nothing is calling it at the moment anyway. And it's about a property which does not belong to the document.
Diffs
-----
sheets/part/Doc.h e8f1f89
sheets/part/Doc.cpp ca41249
Diff: http://git.reviewboard.kde.org/r/108586/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130125/0050ae9d/attachment.htm>
More information about the calligra-devel
mailing list