Review Request 108579: remove file FindKOfficeLibs.cmake.in and a duplicated line for creating FindCalligraLibs.cmake

[Yue Liu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108579/#review26181
-----------------------------------------------------------


One more duplication in the install command in line 6

- Yue Liu


On Jan. 25, 2013, 12:59 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108579/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 12:59 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Seems that in the switch from "Calligra" to "KOffice" FindCalligraLibs.cmake.in was copied from FindKOfficeLibs.cmake.in, but the latter not removed.
> And additionally the old line to turn FindCalligraLibs.cmake.in into FindCalligraLibs.cmake got a nameswitch, instead of being removed.
> 
> But already turning FindCalligraLibs.cmake.in into FindCalligraLibs.cmake once is enough ;)
> 
> Attached patch removes the duplicated line and also the file cmake/modules/FindKOfficeLibs.cmake.in (somehow git diff did not add it to the patch I uploaded).
> 
> Problem found by Yue and reported this morning on #calligra.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/CMakeLists.txt 59f6186 
> 
> Diff: http://git.reviewboard.kde.org/r/108579/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130125/75d9ef6e/attachment.htm>