Review Request 108569: Flake ConfigWidgets and user friendly interface

Thu Jan 24 14:48:11 GMT 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108569/#review26131
-----------------------------------------------------------

Quite nice, a good improvement on the existing UI. I have a bunch of comments on some of the details though. 

File Attachment: Snap Settings Docker
<http://git.reviewboard.kde.org//r/108569/#fcomment6>
    What's this? I'm guessing "enable snapping" but a random checkbox really does not work for that. Though I think this is a larger issue for this docker, tiny buttons with no description and non-obvious icons makes for a hard to learn UI.

File Attachment: Freehand path drawing tool config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment7>
    This...

File Attachment: Freehand path drawing tool config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment8>
    ... is less wide than this, which makes it look unbalanced. Giving them both a sizeHint should solve that.

File Attachment: Freehand path drawing tool config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment9>
    This is using an awful lot of space while the two buttons next to it feel cramped. Try and play a bit with the spacing, you do not necessarily need to align the second row exactly to the first row. It would also help with equalising the width of the two arrow sections.

File Attachment: Freehand path drawing tool config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment10>
    These have inequal heights which looks really awkward. Try and give them the same sizeHint for height.

File Attachment: Default Tools config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment11>
    Why "Line/Border" when you use "Stroke" in the freehand tool? Why not stick with "Stroke" everywhere, considering that was also the term used in the old docker.

File Attachment: Default Tools config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment12>
    Please see the Freehand tool for comments about this area.

File Attachment: Default Tools config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment13>
    "No Fill" is not really distinguishable from "Solid Fill". The "Delete" icon used in the old docker works better, though you might want to use a grayscale variant of that.

File Attachment: Default Tools config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment14>
    The preview is quite small here. What happens with the dropdown, does it have the same size previews?

    Also, how does this look with Gradient fill? Does it use the same small preview?

File Attachment: Default Tools config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment15>
    This has the same issue as the Snap docker. Single checkboxes without apparent context are really confusing.

File Attachment: Default Tools config widgets
<http://git.reviewboard.kde.org//r/108569/#fcomment16>
    Try and fix the alignment here. The labels and widgets for Blur and distance really should be aligned with eachother, now it just looks messy.

File Attachment: Snap Settings Docker
<http://git.reviewboard.kde.org//r/108569/#fcomment17>
    See also the checkbox: 10px. 10px of what?

File Attachment: Snap Settings Docker
<http://git.reviewboard.kde.org//r/108569/#fcomment18>
    I understand this is the current UI. I would really like to see a cleanup of this as a follow up though, since you are already busy with other parts of this UI. Please consider the comments for that follow-up.

- Arjen Hiemstra

On Jan. 24, 2013, 2:12 p.m., Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108569/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 2:12 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch totally changes the design of the tools config widget use. This new way of doing had been discussed with several people (boemann and a UI designer worked 8 hours at the aKademy, and this part is one of the main thing to do. The manipulation of shapes on pages and slides is way easier now. The good widgets appear to you when you select a tool, and you know directly have what you need and want to manipulate the shapes!
> 
> - If you select a tool, it will open the config widgets associated.
> - As you can see on the screenshots, all the tools needs their own widgets.
> - Stroke, Fill and Shadow config widgets are the main one.
> - A same config widget can be used with several tools.
> - Snap Settings had been removed from config widgets and added as a Docker -- the opposite way that the StrokeDocker for instance.
> 
> 
> Diffs
> -----
> 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.h 7de7a14 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp 4833d86 
>   krita/CMakeLists.txt 835f90d 
>   libs/basicflakes/tools/KoCreatePathTool.cpp 043ec2e 
>   libs/widgets/KoFillConfigWidget.cpp PRE-CREATION 
>   libs/widgets/KoResourcePopupAction.cpp PRE-CREATION 
>   libs/widgets/KoShadowConfigWidget.cpp e9e9502 
> 
> Diff: http://git.reviewboard.kde.org/r/108569/diff/
> 
> 
> Testing
> -------
> 
> Tested in the flake-configwidgets-boemann branch, on words and stage, with several documents, and different kind of shapes.
> 
> 
> File Attachments
> ----------------
> 
> Default Tools config widgets
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/DefaultTools.jpg
> New docker list
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/NewDockersList.jpg
> Freehand path drawing tool config widgets
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/PathDrawingTool.jpg
> Snap Settings Docker
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/SnapSettings.jpg
> 
> 
> Thanks,
> 
> Jean-Nicolas Artaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130124/93755915/attachment.htm>