Review Request 108562: Let calligraphy tool use foreground color and cross cursor

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108562/#review26055
-----------------------------------------------------------

Ship it!


Maybe the calligraphy tool was supposed to have an outline as well -- but I don't remember it. In any case, this fixes a long-standing irritation and I'm all for it.

- Boudewijn Rempt


On Jan. 22, 2013, 11:07 p.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108562/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 11:07 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Patch lets the calligraphy tool use a cross cursor and insert new shapes with foreground instead of background. I'm posting as review because it's not clear if it should be using foreground color and I remember there was some reason against it.
> 
> 
> This addresses bugs 313634 and 313636.
>     http://bugs.kde.org/show_bug.cgi?id=313634
>     http://bugs.kde.org/show_bug.cgi?id=313636
> 
> 
> Diffs
> -----
> 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp 6b93e3b 
> 
> Diff: http://git.reviewboard.kde.org/r/108562/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130123/ca1e632f/attachment.htm>