Review Request 108563: Finish removing changetracker code from KoTextWriter

C. Boemann cbr at boemann.dk
Wed Jan 23 05:22:13 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108563/#review26044
-----------------------------------------------------------



libs/kotext/opendocument/KoTextWriter_p.h
<http://git.reviewboard.kde.org/r/108563/#comment19845>

    uhm if you remove this argument does the method do anythin useful anymore?
    can't it be removed completely then



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108563/#comment19846>

    could you please remember the class name KoDeleteChangeMarker
    
    This will be your next task - to remove that



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108563/#comment19847>

    yes as expected it can be removed completely


- C. Boemann


On Jan. 23, 2013, 12:19 a.m., Luke De Mouy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108563/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2013, 12:19 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Finish removing change tracking code from KoTextWriter
> 
> 
> Diffs
> -----
> 
>   libs/kotext/opendocument/KoTextWriter.cpp 8c0f26b 
>   libs/kotext/opendocument/KoTextWriter_p.h b8432aa 
>   libs/kotext/opendocument/KoTextWriter_p.cpp ada521a 
> 
> Diff: http://git.reviewboard.kde.org/r/108563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luke De Mouy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130123/6bd02c68/attachment.htm>


More information about the calligra-devel mailing list