Review Request 108535: Clean out KoTextLoader of changetracking
C. Boemann
cbr at boemann.dk
Tue Jan 22 06:46:11 GMT 2013
> On Jan. 22, 2013, 6:18 a.m., C. Boemann wrote:
> > libs/kotext/opendocument/KoTextLoader.cpp, line 413
> > <http://git.reviewboard.kde.org/r/108535/diff/3/?file=108546#file108546line413>
> >
> > hmm i don't think this should be removed though
> >
>
> Luke De Mouy wrote:
> the loadList call isn't actually removed even though it says it was for some reason, but you can see it still there on the right side.... with a red line of trailing space I need to remove
ok dismiss the issue then
- C.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108535/#review25952
-----------------------------------------------------------
On Jan. 22, 2013, 6:37 a.m., Luke De Mouy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108535/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 6:37 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Clear out the changetracking in KoTextLoader and do a bit more cleanup on KoTextWriter, mainly focused on KoTextLoader though
>
>
> Diffs
> -----
>
> libs/kotext/opendocument/KoTextLoader.h 1c50c16
> libs/kotext/opendocument/KoTextLoader.cpp 218bb8d
> libs/kotext/opendocument/KoTextWriter.cpp 04ae913
> libs/kotext/opendocument/KoTextWriter_p.h b2333b7
> libs/kotext/opendocument/KoTextWriter_p.cpp 5269020
>
> Diff: http://git.reviewboard.kde.org/r/108535/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luke De Mouy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130122/676e5f36/attachment.htm>
More information about the calligra-devel
mailing list