Review Request 108532: Fix crash in krita master on style combo
C. Boemann
cbr at boemann.dk
Tue Jan 22 06:22:46 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108532/#review25954
-----------------------------------------------------------
though i would have made heading etc children of body text, I have no problem with this
And to Sven: yes it's lost unless krita creates a real stylemananger and make sure to save it's contents and load it again
- C. Boemann
On Jan. 21, 2013, 7:41 p.m., Pierre Stirnweiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108532/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2013, 7:41 p.m.)
>
>
> Review request for Calligra, C. Boemann and Sven Langkamp.
>
>
> Description
> -------
>
> Krita crashes in master on the paragraph style combo.
>
>
> This addresses bug 313414.
> http://bugs.kde.org/show_bug.cgi?id=313414
>
>
> Diffs
> -----
>
> libs/kotext/styles/KoStyleManager.h c44ba32
> libs/kotext/styles/KoStyleManager.cpp c2a64e9
> plugins/textshape/TextShapeFactory.cpp d7e8fe8
> plugins/textshape/dialogs/DockerStylesComboModel.cpp 472f8b4
> plugins/textshape/dialogs/StylesModel.cpp a264855
>
> Diff: http://git.reviewboard.kde.org/r/108532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pierre Stirnweiss
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130122/71f40d94/attachment.htm>
More information about the calligra-devel
mailing list