Review Request 108535: Clean out KoTextLoader of changetracking

C. Boemann cbr at boemann.dk
Tue Jan 22 06:15:18 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108535/#review25931
-----------------------------------------------------------



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108535/#comment19818>

    can these 4 really not be removed?



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108535/#comment19808>

    it's:
    Type &arg



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108535/#comment19817>

    trailing space please remove


- C. Boemann


On Jan. 22, 2013, 3:56 a.m., Luke De Mouy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108535/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 3:56 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Clear out the changetracking in KoTextLoader and do a bit more cleanup on KoTextWriter, mainly focused on KoTextLoader though
> 
> 
> Diffs
> -----
> 
>   libs/kotext/opendocument/KoTextLoader.h 1c50c16 
>   libs/kotext/opendocument/KoTextLoader.cpp 218bb8d 
>   libs/kotext/opendocument/KoTextWriter_p.h b2333b7 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 5269020 
> 
> Diff: http://git.reviewboard.kde.org/r/108535/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luke De Mouy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130122/04693da2/attachment.htm>


More information about the calligra-devel mailing list