Review Request 108478: fix for a broken algorithm type comparison in MsooXmlDiagramReader_p.cpp

Sebastian Sauer mail at dipe.org
Mon Jan 21 05:13:39 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108478/#review25877
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Sauer


On Jan. 18, 2013, 9:55 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108478/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 9:55 p.m.)
> 
> 
> Review request for Calligra and Sebastian Sauer.
> 
> 
> Description
> -------
> 
> Saw MSVC complaining about the comparison, indeed broken.
> 
> But I have no clue about the rest of this code, perhaps you still have, Sebastian?
> 
> 
> Diffs
> -----
> 
>   filters/libmsooxml/MsooXmlDiagramReader_p.cpp cd8d47e 
> 
> Diff: http://git.reviewboard.kde.org/r/108478/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130121/13d88ed9/attachment.htm>


More information about the calligra-devel mailing list