Review Request 108509: Fix 313576: Use the doc of the correct part

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108509/#review25867
-----------------------------------------------------------

Ship it!


Looks good to me as well. About your question... I think it's a matter of historical baggage, so if you can sanitize, please do.

- Boudewijn Rempt


On Jan. 20, 2013, 5:50 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108509/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2013, 5:50 p.m.)
> 
> 
> Review request for Calligra, C. Boemann and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> Fix a crash in Auto Recover of files. Use the doc of the part being used.
> 
> I also had a question about bool KoMainWindow::openDocument(KoPart *newPart, KoDocument *newdoc, const KUrl & url)
> Is there any reason to pass separate part and document arguments when newPart->document() returns the document used by the part?
> 
> 
> This addresses bug 313576.
>     http://bugs.kde.org/show_bug.cgi?id=313576
> 
> 
> Diffs
> -----
> 
>   libs/main/KoApplication.cpp ce23241 
> 
> Diff: http://git.reviewboard.kde.org/r/108509/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130120/354d85a4/attachment.htm>