Review Request 108510: split out _data() method for TestBlockLayout::testTabs()

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108510/#review25863
-----------------------------------------------------------

Ship it!


Ship It!

- C. Boemann


On Jan. 20, 2013, 5:50 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108510/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2013, 5:50 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> When investigating the failing TestBlockLayout::testTabs() I split out the data delivery into a separate method.
> 
> Might be worth to keep it in the real codebase as well, as that way in case of fails the index of the test data will be reported, so one does not have to add debug statements to find out for which data it failed.
> 
> E.g. in http://build.kde.org/job/calligra_master/606/testReport/junit/(root)/TestSuite/libs_textlayout_TestBlockLayout/ one has no idea for which "i" it is failing. And if it would fail for more testdata.
> 
> 
> Diffs
> -----
> 
>   libs/textlayout/tests/TestBlockLayout.h c770bd3 
>   libs/textlayout/tests/TestBlockLayout.cpp a642b4e 
> 
> Diff: http://git.reviewboard.kde.org/r/108510/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130120/820fa853/attachment.htm>