Review Request 108505: cleanup calligraactive.desktop

Friedrich W. H. Kossebau kossebau at kde.org
Sun Jan 20 12:04:33 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108505/
-----------------------------------------------------------

Review request for Calligra and Shantanu Tushar.


Description
-------

Two things in the calligraactive.desktop made me wonder:

a) is there a need to give an absolute path to the calligraactive executable with Exec=/usr/bin/calligraactive ?
b) what is the purpose of the Version=27.0 ?

If a) is really needed, then the path here needs to be set at buildtime to the install prefix set for the build, it might be different from /usr/bin. But I guess it is simply unneeded, so the patch just removes the absolute path prefix.

For b) I found no traces in CA's code, might be it just once slipped in accidently and never was wiped again? This is now what the patch does.

Okay to also backport to 2.6?


Diffs
-----

  active/calligraactive.desktop cd595e4 

Diff: http://git.reviewboard.kde.org/r/108505/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130120/787a7877/attachment.htm>


More information about the calligra-devel mailing list