Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108479/#review25775
-----------------------------------------------------------



libs/kotext/opendocument/KoTextLoader.h
<http://git.reviewboard.kde.org/r/108479/#comment19669>

    this can be removed



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19670>

    this line should be removed



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19671>

    remove



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19672>

    remove



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19673>

    remove



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19674>

    entire method can go



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19675>

    trailing space



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19676>

    trailing space



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19677>

    this entire method can go



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19678>

    this entire method can go



libs/kotext/opendocument/KoTextWriter.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19679>

    these two lines should go too



libs/kotext/opendocument/KoTextWriter_p.h
<http://git.reviewboard.kde.org/r/108479/#comment19680>

    this be removale too then



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19681>

    can't this be removed too?



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19682>

    this should be removable too



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19683>

    is this even called anymore - it shuld be removable i think



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19684>

    removable



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19685>

    remove



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19686>

    remove



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19687>

    remove



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19689>

    remove



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19688>

    remove



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19690>

    remove



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19691>

    remove


- C. Boemann


On Jan. 19, 2013, 4:49 a.m., Luke De Mouy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108479/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 4:49 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This strips out the change tracking code in KoTextWriter and KoTextLoader, in order to lay the groundwork for a new change tracking system and collaborative editing.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/opendocument/KoTextLoader.cpp d024996 
>   libs/kotext/opendocument/KoTextLoader.h 03856fb 
>   libs/kotext/opendocument/KoTextWriter.h 357d4bc 
>   libs/kotext/opendocument/KoTextWriter.cpp db5f23d 
>   libs/kotext/opendocument/KoTextWriter_p.h f3466e1 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 39cf629 
> 
> Diff: http://git.reviewboard.kde.org/r/108479/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luke De Mouy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130119/edbf536d/attachment.htm>