Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal
C. Boemann
cbr at boemann.dk
Sat Jan 19 02:20:41 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108479/#review25771
-----------------------------------------------------------
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19624>
this should be left in
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19625>
this block can be left out
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19626>
this needs to stay
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19627>
and all of this block can go
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19628>
this block can go
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19629>
you need to check for != "removed-content" before you do the else part
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19630>
can go
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19631>
more trailing spaces
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19632>
trailing spaces
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19633>
trailing spaces
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19634>
trailing spaces
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19635>
trailing spaces
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19636>
trailing spaces
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19637>
trailing space
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19638>
this entire method should go
which should give you an idea of where else you may miss something
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19639>
trailing spaces
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19640>
trailing spaces
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19641>
this method should go too
libs/kotext/opendocument/KoTextWriter.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19642>
trailing spaces
libs/kotext/opendocument/KoTextWriter.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19643>
trailing spaces
libs/kotext/opendocument/KoTextWriter.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19644>
trailing spaces
libs/kotext/opendocument/KoTextWriter_p.h
<http://git.reviewboard.kde.org/r/108479/#comment19646>
trailing spaces
libs/kotext/opendocument/KoTextWriter_p.h
<http://git.reviewboard.kde.org/r/108479/#comment19647>
trailing spaces
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19648>
this entire method should go
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19649>
trailing space
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19650>
trailing space
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19651>
trailing space
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19652>
trailing space
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19654>
entire method should go
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19653>
trailing space
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19655>
entire method should go
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19656>
entire method should go
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19657>
entire method should go
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19658>
delete this too
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19659>
this entire method should go
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19660>
this entire method should go
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19661>
this entire method should go
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19662>
this entire method should go
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19663>
yes please!
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19665>
tailing spaces
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19666>
trailing spaces
libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19667>
these lines needs to go too
- C. Boemann
On Jan. 19, 2013, 1:48 a.m., Luke De Mouy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108479/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2013, 1:48 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> This strips out the change tracking code in KoTextWriter and KoTextLoader, in order to lay the groundwork for a new change tracking system and collaborative editing.
>
>
> Diffs
> -----
>
> libs/kotext/opendocument/KoTextLoader.h 03856fb
> libs/kotext/opendocument/KoTextLoader.cpp d024996
> libs/kotext/opendocument/KoTextWriter.h 357d4bc
> libs/kotext/opendocument/KoTextWriter.cpp db5f23d
> libs/kotext/opendocument/KoTextWriter_p.h f3466e1
> libs/kotext/opendocument/KoTextWriter_p.cpp 39cf629
>
> Diff: http://git.reviewboard.kde.org/r/108479/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luke De Mouy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130119/90f579f6/attachment.htm>
More information about the calligra-devel
mailing list