Review Request 108476: fix strange code in PictureShape::_Private::generateOutline(...)

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108476/#review25768
-----------------------------------------------------------

Ship it!


i believe you are right - please backport too

- C. Boemann


On Jan. 18, 2013, 7 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108476/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 7 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> MSVC complained about this, I agree as well. Seems to have worked because "first" was "false" here, thus had the value 0.
> Still feels better to just write "0", no?
> 
> Your commit, so I might just have been blind, then tell.
> 
> 
> Diffs
> -----
> 
>   plugins/pictureshape/PictureShape.cpp 1f4eb9e 
> 
> Diff: http://git.reviewboard.kde.org/r/108476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130119/7909901f/attachment.htm>