Review Request 107717: Move ElapsedTime class to a private header that wont be installed

[Friedrich W. H. Kossebau]

> On Dec. 14, 2012, 4:33 p.m., Marijn Kruisselbrink wrote:
> > LGTM
> 
> Philip Hoof wrote:
>     When commtting please use this patch, to avoid conflict on my local branch, using git am (not patch -p1 < etc.diff):
>     
>     http://mail.kde.org/pipermail/calligra-devel/attachments/20121214/1a18be63/attachment.patch
>
> 
> Friedrich W. H. Kossebau wrote:
>     Hi Philip,
>     could you please update the patch and resent it (calligra-devel or directly to me)? Tried to apply, but someone (well, even me) committed stuff in the meantime so your patch does no longer cleanly apply.
>     When updating, please also add a line "REVIEW: 107717" to the description, which will trigger the commit hook to close this review request.

Philip, ping?


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107717/#review23471
-----------------------------------------------------------


On Dec. 14, 2012, 1:39 p.m., Philip Hoof wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107717/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2012, 1:39 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> From 6df02b31d66934ac57a4bce123bab8fcc0dbdf82 Mon Sep 17 00:00:00 2001
> From: Philip Van Hoof <philip at codeminded.be>
> Date: Fri, 14 Dec 2012 14:34:49 +0100
> Subject: [PATCH] Move ElapsedTime class to a private header that wont be
>  installed
> 
> This also fixes a old-style-cast problem in the class's destructor
> 
> 
> Diffs
> -----
> 
>   sheets/ElapsedTime_p.h PRE-CREATION 
>   sheets/Global.h 1759095 
>   sheets/RecalcManager.cpp c5674f2 
>   sheets/part/CanvasBase.cpp f973f40 
>   sheets/part/Headers.cpp f29408f 
>   sheets/part/View.cpp 6a12d45 
>   sheets/DocBase.cpp d67c66d 
>   sheets/DependencyManager.cpp 60e82e8 
> 
> Diff: http://git.reviewboard.kde.org/r/107717/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Philip Hoof
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130118/cbae6e46/attachment.htm>