Review Request 108448: primitive first version of a QTextDocument inspector docker

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108448/#review25728
-----------------------------------------------------------

Ship it!


Ship It!

- C. Boemann


On Jan. 17, 2013, 4:30 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108448/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2013, 4:30 p.m.)
> 
> 
> Review request for Calligra, C. Boemann and Pierre Stirnweiss.
> 
> 
> Description
> -------
> 
> Having used the WebKit inspector to analyze the structure of HTML documents, I, while looking at the problem with the blocks around tables, had the deep desire to have something similar for QTextDocument objects.
> 
> So here is a patch for the very first simple version of such an inspector:
> * shows the structure of the QTextDocument of the currently selected text shape, i.e. the elements and their names (lists are not detected yet as listed, items only shown as normal blocks)
> * view done as a docker
> * is only build in debug builds, so not part of release builds
> 
> Okay to commit to master?
> 
> There are many more things one would like to have, but this is a first working intermediate state and maybe useful to some already. And everybody can start to extend it now, as they like/need/got ideas for. So will I :) But for now some feedback is welcome.
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/CMakeLists.txt 672ed29 
>   plugins/textshape/TextDocumentInspectionDocker.h PRE-CREATION 
>   plugins/textshape/TextDocumentInspectionDocker.cpp PRE-CREATION 
>   plugins/textshape/TextDocumentInspectionDockerFactory.h PRE-CREATION 
>   plugins/textshape/TextDocumentInspectionDockerFactory.cpp PRE-CREATION 
>   plugins/textshape/TextDocumentStructureModel.h PRE-CREATION 
>   plugins/textshape/TextDocumentStructureModel.cpp PRE-CREATION 
>   plugins/textshape/TextPlugin.cpp 9ae621e 
> 
> Diff: http://git.reviewboard.kde.org/r/108448/diff/
> 
> 
> Testing
> -------
> 
> No crash even with OpenDocument-v1.2-part1.odt, just scrolling in the inspector view was slow, but then this is not optimized yet as there are more important things to do.
> 
> 
> File Attachments
> ----------------
> 
> View of the inspector
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/17/TextDocument_inspector.png
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130117/c16bb510/attachment.htm>